-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard fix pod status #4742
Dashboard fix pod status #4742
Conversation
/hold |
I'd leave base statuses as a list of:
We could display additional information on the details view, but on the list view I'd stick to the above 4. |
@floreks okay, I agree with you that display the base statuses as a list of: Running、Pending、Succeded、Failed. But I think we should add some code to handle the case if the pod is terminating because when the pod status is terminating, the pod is not use anymore, but in dashboard, we still display it as running. |
some code such like:
we should take |
So maybe we could add another status like |
when a pod is being deleted:
And the pod status display in More than that, I think we may need to redetermine the status of pods, because if a node loses contact, then all the pods on the node will be in the This PR is written according to |
|
We can add |
okay, I agree with you. And I'd modify this pr and add |
f0b963b
to
dd72cc8
Compare
Codecov Report
@@ Coverage Diff @@
## master #4742 +/- ##
==========================================
- Coverage 45.42% 45.38% -0.04%
==========================================
Files 214 214
Lines 9975 9985 +10
Branches 94 94
==========================================
+ Hits 4531 4532 +1
- Misses 5180 5187 +7
- Partials 264 266 +2
Continue to review full report at Codecov.
|
@@ -46,7 +46,7 @@ func getPodStatus(pod v1.Pod, warnings []common.Event) PodStatus { | |||
} | |||
} | |||
|
|||
// getPodStatusPhase returns one of four pod status phases (Pending, Running, Succeeded, Failed) | |||
// getPodStatusPhase returns one of four pod status phases (Pending, Running, Succeeded, Failed, Unknow, Terminating) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Unknow/Unknown
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@zehuaiWANG Will you update it? |
/hold cancel |
Yes. This is an important PR. Sorry I forgot about it, I think I need to look at it again to make sure there are no new problems. Maybe about next week I will update it. @maciaszczykm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maciaszczykm, zehuaiWANG The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@maciaszczykm I've already tested it and found no problem. Thank you for fixing the typo. |
It's problem with Travis. |
refer to issue #4740
I found that dashboard can not handle the pod terminating status,
BTW, when the pod phase is Running and the DeletionTimestamp is not nil, dashboard will show the pod is Running, but it's Terminating if I use kubectl describe pod
cc @maciaszczykm @floreks @shu-mutou
Please don't merge it now. I think it should be discussed. Maybe the front-end should be changed either.
Above it's some reference about pod status:
How to use the kubernetes go-client to get the same Pod status info that kubectl gives
kubernetes/kubernetes printpod